Skip to content

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Oct 8, 2025

This change makes sure that the random sampling feature flag is enabled for various yaml rest test runners even when running in non-snapshot mode.
Closes #135975
Closes #135989
Closes #135993
Closes #136190

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v9.3.0 labels Oct 8, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Oct 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these muted automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if they fail frequently enough they get automatically muted.

Copy link
Contributor

@seanzatzdev seanzatzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@masseyke masseyke added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 8, 2025
@elasticsearchmachine elasticsearchmachine merged commit 1d8bee7 into elastic:main Oct 8, 2025
34 checks passed
@masseyke masseyke deleted the random-sampling-adding-test-feature-flag branch October 8, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v9.3.0
Projects
None yet
3 participants